Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
M MTSA
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 35
    • Issues 35
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lafhis
  • MTSA
  • Merge requests
  • !17

Merged
Created Oct 07, 2026 by Sebastian Uchitel@suchitelOwner

Reject controllerSpec clauses other than controllable/safety with controlled_det

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 9

A controlled_det composition drives its determinisation purely from the controllable action set (makeControlledDeterminisation reads goal.getControllableActions() and nothing else). The safety clause is also honoured, since its property is composed into the model beforehand via preProcessSafetyReqs. Every other controllerSpec clause (liveness, assumption, reachability, nonblocking, ...) is silently ignored, so a spec that includes one is misleading.

Adds a guard in CompositionExpression.buildAndSetGoal (fired only when isControlledDet) that aborts via Diagnostics.fatal when the goal carries any clause other than controllable or safety.

Adds ControlledDetGoalTest (rejection + no over-fire) and cleans the silently-ignored clauses out of the existing controlled_det fixtures, keeping controllable/safety.

Full suite green (664 tests; TestLTSCompose 150/150).

🤖 Generated with Claude Code

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: bugfix/controlled-det-goal-checks